-
Notifications
You must be signed in to change notification settings - Fork 533
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meta, frontend): support drop cascade for tables, mviews, views, indexes, sources and sinks #11250
Conversation
Codecov Report
@@ Coverage Diff @@
## main #11250 +/- ##
==========================================
+ Coverage 69.67% 69.71% +0.03%
==========================================
Files 1351 1351
Lines 224653 224677 +24
==========================================
+ Hits 156538 156632 +94
+ Misses 68115 68045 -70
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, unifying it made it a lot more maintainable 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
drop_relation
to replacedrop_table
,drop_source
,drop_index
,drop_sink
anddrop_source
in meta.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Click here for Documentation
Types of user-facing changes
Please keep the types that apply to your changes, and remove the others.
Release note