Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support CUBE #11262

Merged
merged 2 commits into from Jul 27, 2023
Merged

feat(frontend): support CUBE #11262

merged 2 commits into from Jul 27, 2023

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR contains user-facing changes.
Click here for Documentation

Types of user-facing changes

Please keep the types that apply to your changes, and remove the others.

  • Installation and deployment
  • Connector (sources & sinks)
  • SQL commands, functions, and operators
  • RisingWave cluster configuration changes
  • Other (please specify in the release note below)

Release note

  • Support Cube in group-by clauses.

@chenzl25 chenzl25 requested review from stdrc and BugenZhao July 27, 2023 04:30
@chenzl25 chenzl25 added user-facing-changes Contains changes that are visible to users type/feature and removed type/feature labels Jul 27, 2023
Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chenzl25 chenzl25 enabled auto-merge July 27, 2023 05:34
@chenzl25 chenzl25 added this pull request to the merge queue Jul 27, 2023
Copy link
Contributor

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Merged via the queue into main with commit 0d549d7 Jul 27, 2023
32 of 34 checks passed
@chenzl25 chenzl25 deleted the dylan/support_cube branch July 27, 2023 06:21
@emile-00 emile-00 added the 📖✓ Covered or will be covered in the user docs. label Jul 31, 2023
@chenzl25 chenzl25 mentioned this pull request Aug 2, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users 📖✓ Covered or will be covered in the user docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants