Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support pg_relation_size #11687

Merged
merged 2 commits into from
Aug 16, 2023
Merged

feat: support pg_relation_size #11687

merged 2 commits into from
Aug 16, 2023

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Aug 15, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #10816

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Aug 15, 2023

Codecov Report

Merging #11687 (ebd110a) into main (9d99c02) will decrease coverage by 0.01%.
Report is 24 commits behind head on main.
The diff coverage is 39.28%.

@@            Coverage Diff             @@
##             main   #11687      +/-   ##
==========================================
- Coverage   70.31%   70.30%   -0.01%     
==========================================
  Files        1365     1365              
  Lines      227709   227765      +56     
==========================================
+ Hits       160103   160122      +19     
- Misses      67606    67643      +37     
Flag Coverage Δ
rust 70.30% <39.28%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/frontend/src/binder/expr/function.rs 83.06% <39.28%> (-2.34%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hzxa21 hzxa21 added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 2572d86 Aug 16, 2023
36 of 37 checks passed
@hzxa21 hzxa21 deleted the patrick/pg-relation-size branch August 16, 2023 05:06
@neverchanje neverchanje added the user-facing-changes Contains changes that are visible to users label Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pg_relation_size() not working
4 participants