New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): add regexp_replace
#11819
Conversation
Please add some e2e tests in |
Now we only support |
In addition, now the |
Codecov Report
@@ Coverage Diff @@
## main #11819 +/- ##
==========================================
- Coverage 70.21% 70.11% -0.10%
==========================================
Files 1380 1380
Lines 231054 231357 +303
==========================================
- Hits 162232 162226 -6
- Misses 68822 69131 +309
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
New version updated, the left problems may be further reviewed. |
If now the overall picture looks good, I will merge it after removing the debug statement. |
I've updated the latest version and most of the problems have been resolved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
query T | ||
select regexp_replace('💩💩💩💩💩foo🤔️bar亲爱的😭baz这不是爱情❤️🔥', 'baz(...)', '这是🥵', 'ic'); | ||
---- | ||
💩💩💩💩💩foo🤔️bar亲爱的😭这是🥵爱情❤️🔥 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #11723
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
Support
regexp_replace