Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(parser): parse lambda function (take 2) #11888

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

TennyZhuang
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Use |x| x + 1 as syntax to avoid ambiguity

Resolve #11838

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Signed-off-by: TennyZhuang <zty0826@gmail.com>
@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #11888 (b311800) into main (9c89aa0) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is 93.33%.

@@           Coverage Diff           @@
##             main   #11888   +/-   ##
=======================================
  Coverage   70.20%   70.20%           
=======================================
  Files        1375     1375           
  Lines      229075   229090   +15     
=======================================
+ Hits       160813   160827   +14     
- Misses      68262    68263    +1     
Flag Coverage Δ
rust 70.20% <93.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/meta/src/manager/catalog/utils.rs 48.79% <0.00%> (-0.17%) ⬇️
src/sqlparser/src/ast/mod.rs 85.36% <100.00%> (+0.07%) ⬆️
src/sqlparser/src/parser.rs 86.55% <100.00%> (+0.02%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify, this means | cannot be used as a prefix operator in future version (builtin or create operator)

Update: a PostgreSQL-compatible workaround exists: operator(pg_catalog.|) operand or operator(public.|) operand

@TennyZhuang TennyZhuang added this pull request to the merge queue Aug 25, 2023
Merged via the queue into main with commit 08c2a36 Aug 25, 2023
35 of 36 checks passed
@TennyZhuang TennyZhuang deleted the parse-lambda-function-2 branch August 25, 2023 10:17
Li0k pushed a commit that referenced this pull request Sep 15, 2023
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse lambda function
3 participants