-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(expr): add regexp_count
#11975
feat(expr): add regexp_count
#11975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 4020 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
1771 | 1 | 2248 | 0 |
Click to see the invalid file list
- src/expr/src/expr/expr_regexp_count.rs
Syntax of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM.
Codecov Report
@@ Coverage Diff @@
## main #11975 +/- ##
==========================================
- Coverage 69.90% 69.86% -0.04%
==========================================
Files 1389 1390 +1
Lines 232946 233066 +120
==========================================
- Hits 162840 162838 -2
- Misses 70106 70228 +122
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cc @TennyZhuang @wangrunji0408, I'm ready to merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good work.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
resolve #11735
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
support
regexp_count