Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: downgrade to openssl@1 temporarily #12219

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 12, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

#12198

Don't know how to fix it quickly

image

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested a review from a team as a code owner September 12, 2023 00:00
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #12219 (e1d3227) into main (3c0284e) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12219      +/-   ##
==========================================
- Coverage   69.78%   69.78%   -0.01%     
==========================================
  Files        1408     1408              
  Lines      235754   235754              
==========================================
- Hits       164520   164519       -1     
- Misses      71234    71235       +1     
Flag Coverage Δ
rust 69.78% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@wangrunji0408 wangrunji0408 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into main with commit 862ed5e Sep 12, 2023
39 of 40 checks passed
@wangrunji0408 wangrunji0408 deleted the xxchan/openssl branch September 12, 2023 03:57
@xiangjinwu
Copy link
Contributor

xiangjinwu commented Nov 30, 2023

Just retried with openssl 0.10.60 -> openssl-sys 0.9.96 and it seems to build successfully:
https://buildkite.com/risingwavelabs/docker/builds/14750

Does the error only happen in some cases that I need to provide as build arguments? If not we may simply upgrade them now.

^ Need to specify BINARY_NAME as environment variable.

@xxchan
Copy link
Member Author

xxchan commented Nov 30, 2023

Docker is OK. The problem is for pre-built binary, which uses very old linux.

@xxchan
Copy link
Member Author

xxchan commented Nov 30, 2023

See #13746 for my latest failed attemps 🤡 I do need some help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants