-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: build dashboard in Dockerfile #12421
Conversation
This reverts commit 88ff60c.
Codecov Report
@@ Coverage Diff @@
## main #12421 +/- ##
=======================================
Coverage 69.67% 69.68%
=======================================
Files 1422 1422
Lines 235791 235791
=======================================
+ Hits 164294 164303 +9
+ Misses 71497 71488 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for the docker build
results.
const nextConfig = { | ||
trailingSlash: true, | ||
|
||
rewrites: () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may use phase
to enable rewrites conditionally on development builds.
Tested with
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #8380
Also some misc improvements
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.