Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build dashboard in Dockerfile #12421

Merged
merged 12 commits into from
Sep 19, 2023
Merged

chore: build dashboard in Dockerfile #12421

merged 12 commits into from
Sep 19, 2023

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 19, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #8380

Also some misc improvements

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #12421 (ad3bc7a) into main (ed96064) will increase coverage by 0.00%.
Report is 4 commits behind head on main.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main   #12421   +/-   ##
=======================================
  Coverage   69.67%   69.68%           
=======================================
  Files        1422     1422           
  Lines      235791   235791           
=======================================
+ Hits       164294   164303    +9     
+ Misses      71497    71488    -9     
Flag Coverage Δ
rust 69.68% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/risedevtool/config/src/main.rs 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for the docker build results.

const nextConfig = {
trailingSlash: true,

rewrites: () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may use phase to enable rewrites conditionally on development builds.

https://nextjs.org/docs/pages/api-reference/next-config-js

@xxchan
Copy link
Member Author

xxchan commented Sep 19, 2023

Tested with

docker run -it --rm -p 4566:4566 -p 5691:5691  ghcr.io/risingwavelabs/risingwave:git-ad3bc7a80f115f5800824c209eaed8b72c6e908c playground

@xxchan xxchan added this pull request to the merge queue Sep 19, 2023
Merged via the queue into main with commit f6dff66 Sep 19, 2023
33 of 34 checks passed
@xxchan xxchan deleted the xxchan/dashboard branch September 19, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build dashboard in Dockerfile
2 participants