Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(agg): support jsonb_agg and jsonb_object_agg in streaming mode #12836

Merged
merged 3 commits into from Oct 16, 2023

Conversation

stdrc
Copy link
Contributor

@stdrc stdrc commented Oct 13, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

  • Support jsonb_agg and jsonb_object_agg in streaming mode

Signed-off-by: Richard Chien <stdrc@outlook.com>
Signed-off-by: Richard Chien <stdrc@outlook.com>
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #12836 (2869891) into main (58e6f9d) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

@@            Coverage Diff             @@
##             main   #12836      +/-   ##
==========================================
- Coverage   69.06%   69.06%   -0.01%     
==========================================
  Files        1487     1487              
  Lines      244680   244685       +5     
==========================================
- Hits       168994   168992       -2     
- Misses      75686    75693       +7     
Flag Coverage Δ
rust 69.06% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/expr/core/src/aggregate/def.rs 69.66% <ø> (ø)
src/stream/src/executor/aggregation/minput.rs 97.53% <100.00%> (ø)
...rc/frontend/src/optimizer/plan_node/generic/agg.rs 91.44% <16.66%> (-0.81%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stdrc stdrc added this pull request to the merge queue Oct 13, 2023
@stdrc stdrc removed this pull request from the merge queue due to a manual request Oct 13, 2023
@stdrc stdrc enabled auto-merge October 16, 2023 04:31
@stdrc stdrc added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit f8de4a9 Oct 16, 2023
27 of 28 checks passed
@stdrc stdrc deleted the rc/jsonb-agg-streaming branch October 16, 2023 04:58
@stdrc stdrc added the user-facing-changes Contains changes that are visible to users label Oct 16, 2023
stdrc added a commit that referenced this pull request Oct 16, 2023
…de (#12836)

Signed-off-by: Richard Chien <stdrc@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants