Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(expr): substring/substr for bytea #13088

Merged
merged 2 commits into from Oct 26, 2023
Merged

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

Support substring/substr for bytea

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #13088 (5d174dd) into main (46d2ff9) will increase coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 29.41%.

@@            Coverage Diff             @@
##             main   #13088      +/-   ##
==========================================
+ Coverage   68.23%   68.31%   +0.07%     
==========================================
  Files        1501     1501              
  Lines      252614   252629      +15     
==========================================
+ Hits       172364   172571     +207     
+ Misses      80250    80058     -192     
Flag Coverage Δ
rust 68.31% <29.41%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/expr/impl/src/scalar/substr.rs 85.00% <29.41%> (-13.47%) ⬇️

... and 21 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 26, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 26, 2023
@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 26, 2023
Merged via the queue into main with commit 4a8b0cb Oct 26, 2023
26 of 27 checks passed
@xiangjinwu xiangjinwu deleted the feat-expr-bytea-substr branch October 26, 2023 16:06
@xiangjinwu xiangjinwu added the user-facing-changes Contains changes that are visible to users label Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants