Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rw_internal_tables #13272

Merged
merged 1 commit into from
Nov 6, 2023
Merged

feat: add rw_internal_tables #13272

merged 1 commit into from
Nov 6, 2023

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Nov 6, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Add rw_internal_tables to show internal table information.

Motivation:
Currently the only way to display internal table information via SQL is show internal tables. However, since we cannot join show internal tables, some information is hard to fetch. For example, we don't have a way to associate SST information (e.g. delete_ratio) with internal table name.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #13272 (acd7e81) into main (a0b545c) will decrease coverage by 0.01%.
The diff coverage is 3.03%.

@@            Coverage Diff             @@
##             main   #13272      +/-   ##
==========================================
- Coverage   68.05%   68.05%   -0.01%     
==========================================
  Files        1518     1519       +1     
  Lines      257603   257636      +33     
==========================================
+ Hits       175319   175332      +13     
- Misses      82284    82304      +20     
Flag Coverage Δ
rust 68.05% <3.03%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/frontend/src/catalog/system_catalog/mod.rs 94.69% <100.00%> (+0.02%) ⬆️
...og/system_catalog/rw_catalog/rw_internal_tables.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hzxa21 hzxa21 added this pull request to the merge queue Nov 6, 2023
Merged via the queue into main with commit 8092a68 Nov 6, 2023
28 of 29 checks passed
@hzxa21 hzxa21 deleted the patrick/rw_internal_tables branch November 6, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants