Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(datagen): support timestamptz #13451

Merged
merged 3 commits into from Nov 16, 2023
Merged

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Resolves #8550. The same set of timestamp options can be used for timestamptz fields:

  • max_past
  • max_past_mode
  • basetime

https://docs.risingwave.com/docs/current/ingest-from-datagen/#with-options---column_parameter

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

The datagen source can now generate timestamptz columns.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (fb7fa70) 68.39% compared to head (69fd5a3) 68.39%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/connector/src/source/datagen/source/reader.rs 0.00% 14 Missing ⚠️
src/common/src/array/data_chunk.rs 0.00% 7 Missing ⚠️
src/common/src/field_generator/timestamp.rs 81.25% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13451   +/-   ##
=======================================
  Coverage   68.39%   68.39%           
=======================================
  Files        1501     1501           
  Lines      258488   258536   +48     
=======================================
+ Hits       176794   176828   +34     
- Misses      81694    81708   +14     
Flag Coverage Δ
rust 68.39% <55.55%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 16, 2023
Merged via the queue into main with commit c6dffdf Nov 16, 2023
26 of 27 checks passed
@xiangjinwu xiangjinwu deleted the feat-8550-datagen-timestamptz branch November 16, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datagen connector should support TimestampTz
2 participants