New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stream): backfill resuming for sink #13665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Maybe we should add a user-facing tag.
d648ff4
to
6920f1e
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #13665 +/- ##
==========================================
- Coverage 68.31% 68.31% -0.01%
==========================================
Files 1523 1523
Lines 261833 261872 +39
==========================================
+ Hits 178878 178885 +7
- Misses 82955 82987 +32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/// 3. `Immediate`. Immediate jobs will immediately return, | ||
/// but still register the lag between the job and its upstream. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't find this variant? 👀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in https://github.com/risingwavelabs/risingwave/pull/13735/files, thanks!
It was used previously to indicate a new variant of stream job handling, but I realize I can just use a TrackingCommand without notifiers to accomplish the same thing, with less refactoring.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Closes #12080.
(rw_ddl_progress)
is unsupported currently. I will work on that separately.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
SINK
DDL statements no longer need to wait for backfill to complete.