feat(sqlparser): support literal integers in hex / oct / bin #14262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
commented
Dec 28, 2023
Comment on lines
-542
to
-549
| if s.chars().all(|x| x.is_ascii_digit() || x == '.') { | ||
| let mut s = peeking_take_while(&mut s.chars().peekable(), |ch| { | ||
| ch.is_ascii_digit() || ch == '.' | ||
| }); | ||
| let s2 = peeking_take_while(chars, |ch| ch.is_ascii_digit() || ch == '.'); | ||
| s += s2.as_str(); | ||
| return Ok(Some(Token::Number(s))); | ||
| } |
There was a problem hiding this comment.
This hack was here because HiveQL identifier can start with 0..=9
https://github.com/sqlparser-rs/sqlparser-rs/pull/235/files
TennyZhuang
approved these changes
Dec 28, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolves #14096. The new syntax was added in PostgreSQL 16 for SQL 202x.
Limitations:
0xdead_beef)'0x20'::int/ source ingestion / pgwire text protocol)Breaking change:
0b10, older version interprets it as0 as b10but new versions interprets it as binary10(=2in decimal). It was not an issue in PostgreSQL because such input has always been considered invalid and we are now rejecting0c10similarly.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
Integer literals can now be given in hex
0x, oct0oand bin0b.