Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rw_fragment_parallelism and re-define rw_streaming_parallelism #14789

Merged
merged 1 commit into from Jan 25, 2024

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Jan 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, changed rw_streaming_parallelism to display job level parallelism info and introduced rw_fragment_parallelism for fragment level. Related #14261 . An example as follows:

dev=> select * from rw_streaming_parallelism;
  id  | name |   relation_type   | parallelism
------+------+-------------------+-------------
 1001 | t    | table             | FIXED(4)
 1002 | mv1  | materialized view | AUTO
 1004 | idx  | index             | AUTO
(3 rows)

dev=> select * from rw_fragment_parallelism;
  id  | name |   relation_type   | fragment_id | distribution_type | state_table_ids | upstream_fragment_ids |        flags        | parallelism
------+------+-------------------+-------------+-------------------+-----------------+-----------------------+---------------------+-------------
 1001 | t    | table             |           2 | HASH              | {}              | {}                    | {SOURCE,DML}        |           4
 1001 | t    | table             |           1 | HASH              | {1001}          | {2}                   | {MVIEW}             |           4
 1002 | mv1  | materialized view |           3 | HASH              | {1003,1002}     | {1}                   | {MVIEW,STREAM_SCAN} |           4
 1004 | idx  | index             |           5 | HASH              | {1005}          | {1}                   | {STREAM_SCAN}       |           4
 1004 | idx  | index             |           4 | HASH              | {1004}          | {5}                   | {MVIEW}             |           4
(5 rows)

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

  1. Change system view rw_streaming_parallelism to allow query on streaming job parallelism with job name and type.
  2. Add system view rw_fragment_parallelism to allow query parallelism info on fragment level, together with some fragment info.

@yezizp2012 yezizp2012 added the user-facing-changes Contains changes that are visible to users label Jan 25, 2024
Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done. Exactly what I need!

@yezizp2012 yezizp2012 added this pull request to the merge queue Jan 25, 2024
Merged via the queue into main with commit 90a2139 Jan 25, 2024
32 of 33 checks passed
@yezizp2012 yezizp2012 deleted the feat/rw_fragment_parallelism branch January 25, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants