fix: deny create MV on shared CDC source #15635
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
| @@ -100,6 +101,10 @@ pub trait WithPropertiesExt: Get { | |||
| connector.contains("-cdc") | |||
| } | |||
|
|
|||
| fn is_shared_cdc_source(&self) -> bool { | |||
| self.is_cdc_connector() && CdcTableType::from_properties(self).can_backfill() | |||
There was a problem hiding this comment.
I'm not sure what's the case for non-shared CDC ('citus-cdc'). Will CREATE SOURCE for it be rejected (and when?)
There was a problem hiding this comment.
Actually we cannot distinguish whether it is going to create a share source from properties only. is_shared_cdc_source should not provided in the trait.
There was a problem hiding this comment.
Can you elaborate? This is just extracted from the current implementation in create_source. What it should be like?
There was a problem hiding this comment.
Yeah, because we do this check in create_source, so the context is to create a Source. But if without this context, we cannot distinguish it. is_shared_cdc_source in the trait can be called in other place.
There was a problem hiding this comment.
Fair enough.
BTW, what are the other cases? When don't we create shared CDC source for mysql-cdc? (Do you mean CREATE TABLE directly? Any other cases?)
And the original question: Can we CREATE SOURCE for citus-cdc? If not, where is it rejected?
There was a problem hiding this comment.
BTW, what are the other cases? When don't we create shared CDC source for mysql-cdc? (Do you mean CREATE TABLE directly? Any other cases?)
CREATE TABLE directly, no other cases.
And the original question: Can we CREATE SOURCE for citus-cdc? If not, where is it rejected?
We can't. But it seems we didn't ban it in code.
// gated the feature with a session variable
let create_cdc_source_job = if with_properties.is_cdc_connector() {
CdcTableType::from_properties(&with_properties).can_backfill()
} else {
false
};
There was a problem hiding this comment.
I renamed the function to is_backfillable_cdc_connector. I think there won't be any confusion now.
For BoundSource, we can call its method is_shared_cdc_source
There was a problem hiding this comment.
For BoundSource, we can call its method is_shared_cdc_source
Seems not true. CREATE TABLE will also have a Source node.. Let me just call it is_backfillable_cdc_connector
xxchan
force-pushed
the
03-12-fix_deny_create_MV_on_shared_CDC_source
branch
from
92e20d1
to
9c44201
Compare
There was a problem hiding this comment.
the impl LGTM may ask @StrikeW whether this approach meets expectation
Merge activity
|
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #13955
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.