feat(sink): support delta sink with gcs #16182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenym1
approved these changes
Apr 7, 2024
fuyufjh
reviewed
Apr 8, 2024
src/connector/src/sink/deltalake.rs
Outdated
| let mut storage_options = HashMap::new(); | ||
| storage_options.insert( | ||
| GCS_SERVICE_ACCOUNT.to_string(), | ||
| self.gcs_service_account.clone().unwrap(), |
There was a problem hiding this comment.
If the gcs_service_account is not specified, the CN will panic?
If so, sounds unacceptable to me. Please do validation when create sink
There was a problem hiding this comment.
The fix is inside create_deltalake_client(), you are sure that it will be called during create sink, right?
There was a problem hiding this comment.
Yes, It will call it on create sink and sink write, create sinkis called first, so when the user just makes a write error, it will report the error to the psql client, not recovery
fuyufjh
approved these changes
Apr 8, 2024
src/connector/src/sink/deltalake.rs
Outdated
| storage_options.insert( | ||
| GCS_SERVICE_ACCOUNT.to_string(), | ||
| self.gcs_service_account.clone().ok_or_else(|| { | ||
| SinkError::Config(anyhow!("gcs.service.account is required with aws gcs")) |
There was a problem hiding this comment.
not aws
Suggested change
| SinkError::Config(anyhow!("gcs.service.account is required with aws gcs")) | |
| SinkError::Config(anyhow!("gcs.service.account is required with Google Cloud Storage (GCS)")) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
#16140
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
we can create delta lake sink with gcs the option is :
location = 'gs://bucket/xxx’
gcs.service.account = ‘service account json string’