Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avro): parse decimals with shorter bytes correctly #16202

Merged
merged 4 commits into from
Apr 9, 2024

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Apr 8, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

See risingwavelabs/avro#3. In short, given decimal(10, 2) it would need 5 bytes to store its maximum. When decoding an actual decimal with 4 or few bytes (e.g. simply 0 or 42), the upstream library reports an error (wrong comparison due to misconception similar to the missing dollar riddle).

Actual fix is in the forked library, while this PR just bumps the commit and adds a test. To test decimal (a logical type over bytes in avro), we had to update the test input format: it used to be plain json but switches to the json encoding (contrasting to binary encoding in kafka) of avro. The first commit of this PR is this pure test-refactor but not a standalone PR to ease cherry-picking into release branch.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xiangjinwu xiangjinwu requested a review from a team as a code owner April 8, 2024 13:13
@github-actions github-actions bot added the type/fix Bug fix label Apr 8, 2024
@xiangjinwu xiangjinwu added this pull request to the merge queue Apr 9, 2024
Merged via the queue into main with commit 6e759c2 Apr 9, 2024
36 of 37 checks passed
@xiangjinwu xiangjinwu deleted the fix-source-avro-resolve-decimal branch April 9, 2024 04:32
github-merge-queue bot pushed a commit that referenced this pull request Apr 9, 2024
Co-authored-by: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants