-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(compaction): put all compaction metrics into a grafana graph #1624
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1624 +/- ##
==========================================
- Coverage 70.71% 70.71% -0.01%
==========================================
Files 611 611
Lines 79900 79896 -4
==========================================
- Hits 56504 56500 -4
Misses 23396 23396
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
68d703b
to
2440ec0
Compare
2440ec0
to
85eefe3
Compare
85eefe3
to
71b7ed3
Compare
@@ -59,7 +59,7 @@ | |||
"fiscalYearStartMonth": 0, | |||
"graphTooltip": 0, | |||
"id": 2, | |||
"iteration": 1648803156530, | |||
"iteration": 1650019185521, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, what is the meaning of iteration
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is randomly generated by grafana dashboard, every time someone changes dashboard and export it, iteration
will be redistributed.
Cool! We now have IO metrics for compaction! @soundOfDestiny However, when I tried running e2e using your branch, it looks like some of the metrics always remain zero even after compaction ran successfully. Can you take a look? |
stat logic of these metrics are temporarily removed in #1328, and will be added back in a following PR |
What's changed and what's your intention?
Checklist
Refer to a related PR or issue link (optional)