Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(compaction): put all compaction metrics into a grafana graph #1624

Merged
merged 2 commits into from
Apr 18, 2022

Conversation

soundOfDestiny
Copy link
Contributor

What's changed and what's your intention?

  • put all compaction metrics into a grafana graph

Checklist

Refer to a related PR or issue link (optional)

@soundOfDestiny
Copy link
Contributor Author

截屏2022-04-07 上午9 53 43

@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #1624 (85eefe3) into main (9a2e867) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 85eefe3 differs from pull request most recent head 71b7ed3. Consider uploading reports for the commit 71b7ed3 to get more accurate results

@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
- Coverage   70.71%   70.71%   -0.01%     
==========================================
  Files         611      611              
  Lines       79900    79896       -4     
==========================================
- Hits        56504    56500       -4     
  Misses      23396    23396              
Flag Coverage Δ
rust 70.71% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/storage/src/hummock/value.rs 89.09% <100.00%> (-0.39%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.00% <0.00%> (-0.27%) ⬇️
src/common/src/types/ordered_float.rs 23.50% <0.00%> (-0.20%) ⬇️
src/meta/src/stream/stream_manager.rs 72.50% <0.00%> (+0.41%) ⬆️
src/connector/src/filesystem/file_common.rs 80.88% <0.00%> (+0.44%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2022

CLA assistant check
All committers have signed the CLA.

@@ -59,7 +59,7 @@
"fiscalYearStartMonth": 0,
"graphTooltip": 0,
"id": 2,
"iteration": 1648803156530,
"iteration": 1650019185521,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious, what is the meaning of iteration?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is randomly generated by grafana dashboard, every time someone changes dashboard and export it, iteration will be redistributed.

@hzxa21
Copy link
Collaborator

hzxa21 commented Apr 15, 2022

Cool! We now have IO metrics for compaction!

image

@soundOfDestiny However, when I tried running e2e using your branch, it looks like some of the metrics always remain zero even after compaction ran successfully. Can you take a look?

@soundOfDestiny
Copy link
Contributor Author

Cool! We now have IO metrics for compaction!

image

@soundOfDestiny However, when I tried running e2e using your branch, it looks like some of the metrics always remain zero even after compaction ran successfully. Can you take a look?

stat logic of these metrics are temporarily removed in #1328, and will be added back in a following PR

@soundOfDestiny soundOfDestiny merged commit cbe3040 into main Apr 18, 2022
@soundOfDestiny soundOfDestiny deleted the zl_grpacts branch April 18, 2022 10:12
@zwang28 zwang28 mentioned this pull request Apr 24, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants