Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix the inconsistency issue with the two-stage write to the meta store for sink into table #16305

Merged
merged 6 commits into from
May 9, 2024

Conversation

shanicky
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel
Copy link
Contributor

Cherry pick into 1.8?

Copy link
Contributor

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx for this PR.

src/meta/src/controller/catalog.rs Outdated Show resolved Hide resolved
@shanicky shanicky requested a review from yezizp2012 May 9, 2024 07:13
@shanicky shanicky added need-cherry-pick-release-1.8 need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.9 after the current PR is merged labels May 9, 2024
@shanicky shanicky enabled auto-merge May 9, 2024 07:15
@shanicky shanicky added this pull request to the merge queue May 9, 2024
Merged via the queue into main with commit cb8a92a May 9, 2024
36 of 37 checks passed
@shanicky shanicky deleted the peng/fix-dirty-upstream-main branch May 9, 2024 08:17
github-actions bot pushed a commit that referenced this pull request May 9, 2024
shanicky added a commit that referenced this pull request May 9, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 9, 2024
… store for sink into table (#16305) (#16656)

Co-authored-by: Shanicky Chen <peng@risingwave-labs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-e2e-single-node-tests need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.9 after the current PR is merged type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants