Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): add stream_job_status to TableCatalog #16398

Merged
merged 4 commits into from
Apr 19, 2024
Merged

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Apr 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

To make sure TableCatalog and Table are isomorphic.

Also required by ALTER MV for rate limit on creating mv. See: #16399

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel kwannoel changed the title refactor(frontend): add stream_job_status to TableCatalog fix(frontend): add stream_job_status to TableCatalog Apr 19, 2024
@github-actions github-actions bot added type/fix Bug fix and removed type/refactor labels Apr 19, 2024
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, only the table with created status would be notified to the frontend node. In which case, do we need to handle creating mv in the frontend node?

@kwannoel
Copy link
Contributor Author

IIRC, only the table with created status would be notified to the frontend node. In which case, do we need to handle creating mv in the frontend node?

Yes, in a separate PR I will add that logic. Without the creating mv catalog in the frontend, we can't alter its rate limit, since we don't have sufficient info about its schema, database. Those info are in its TableCatalog.

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kwannoel kwannoel added this pull request to the merge queue Apr 19, 2024
Merged via the queue into main with commit be57d0a Apr 19, 2024
31 of 32 checks passed
@kwannoel kwannoel deleted the kwannoel/bg-catalog branch April 19, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants