Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): Bump avro to support default for bytes/fixed/decimal #16414

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

xiangjinwu
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fixed 2 issues in the forked avro library when Schema::parse_str on a schema containing default:

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xiangjinwu xiangjinwu requested a review from a team as a code owner April 19, 2024 12:49
@github-actions github-actions bot added the type/fix Bug fix label Apr 19, 2024
@xiangjinwu xiangjinwu marked this pull request as draft April 21, 2024 06:12
@xiangjinwu xiangjinwu force-pushed the bump-avro-default-bytes-decimal branch from 193a1a3 to ee673fa Compare April 22, 2024 04:27
@xiangjinwu xiangjinwu marked this pull request as ready for review April 22, 2024 04:27
@sandipdev2020
Copy link

@xiangjinwu thank you for putting this fix, just wondering, do we plan to release this anytime soon?

@xiangjinwu xiangjinwu added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@xiangjinwu xiangjinwu added this pull request to the merge queue Apr 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 23, 2024
@xiangjinwu xiangjinwu added this pull request to the merge queue Apr 23, 2024
Merged via the queue into main with commit 029ac45 Apr 23, 2024
27 of 28 checks passed
@xiangjinwu xiangjinwu deleted the bump-avro-default-bytes-decimal branch April 23, 2024 11:11
github-merge-queue bot pushed a commit that referenced this pull request Apr 23, 2024
…mal` (#16414) (#16453)

Co-authored-by: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants