feat(cdc): introduce with option to configure cdc snapshot #16426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
StrikeW
changed the title
…' into siyuan/cdc-snapshot-options-test
StrikeW
force-pushed
the
siyuan/cdc-snapshot-options
branch
from
1a11d29
to
e13726a
Compare
fuyufjh
approved these changes
Apr 28, 2024
BugenZhao
reviewed
Apr 28, 2024
| Self { | ||
| disable_backfill: false, | ||
| snapshot_barrier_interval: 1, | ||
| snapshot_batch_size: 1000, |
There was a problem hiding this comment.
Should we follow the batch_size specified in the config file instead?
| pub use upstream_table::external::ExternalStorageTable; | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| pub struct CdcScanOptions { |
There was a problem hiding this comment.
It appears to be a duplicate of the one defined in the frontend crate with the same name. Can we merge them?
Comment on lines
+99
to
+102
| let options = scan_options.unwrap_or(CdcScanOptions { | ||
| disable_backfill, | ||
| ..Default::default() | ||
| }); |
There was a problem hiding this comment.
I would suggest moving this into from_proto so that we can accept a single field of scan_options: CdcScanOptions in new.
2 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Introduce
snapshot.intervalandsnapshot.batch_sizeWITH options to create a table from cdc source.snapshot.interval: barrier interval for buffering upstream eventssnapshot.batch_size: batch size for snapshot read to upstream tablefollow up of #16349
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Introduce
snapshot.intervalandsnapshot.batch_sizeWITH options to create a table from cdc source.snapshot.interval: barrier interval for buffering upstream events, default to 1snapshot.batch_size: batch size for snapshot read to upstream table, default to 1000