Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(memory): add reserved_memory_bytes opt #16433

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

hzxa21
Copy link
Collaborator

@hzxa21 hzxa21 commented Apr 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Related #16130

Prior to this PR, reserved memory for compute node is hardcoded to 30% * total available memory, which may be too much under certain workload and machine set-up. This PR adds a compute node opt for user to configure the reserved memory bytes explicitly, with the default behavior unchanged.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

reserved_memory_bytes startup opt and RW_RESERVED_MEMORY_BYTES env are introduced for compute node to override the reserved memory configuration.

The default setup remains unchanged, which is compute node using 30% of its total memory as the reserved memory.

Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@hzxa21 hzxa21 changed the title feat(memory): add reserved_mmemory_bytes opt feat(memory): add reserved_memory_bytes opt Apr 23, 2024
@hzxa21 hzxa21 added the user-facing-changes Contains changes that are visible to users label Apr 23, 2024
@hzxa21 hzxa21 added this pull request to the merge queue Apr 24, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 24, 2024
@hzxa21 hzxa21 added this pull request to the merge queue Apr 24, 2024
Merged via the queue into main with commit dd57b28 Apr 24, 2024
38 of 39 checks passed
@hzxa21 hzxa21 deleted the patrick/memory-config branch April 24, 2024 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants