feat(risedev): use docker for kafka service #16536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
BugenZhao
force-pushed
the
bz/risedev-docker-kafka
branch
from
3c01da2
to
701c133
Compare
BugenZhao
changed the title
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
kwannoel
added
the
ci/run-backwards-compat-tests
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
stdrc
approved these changes
May 24, 2024
| fn kafka(&self) -> Result<Command> { | ||
| Ok(Command::new(self.kafka_path()?)) | ||
| fn image(&self) -> String { | ||
| "confluentinc/cp-kafka:7.6.1".to_owned() |
There was a problem hiding this comment.
Is it possible to have a place define all the versions of such docker images? Also is it possible to clean old versions of these images if we later upgrade the version?
There was a problem hiding this comment.
Is it possible to have a place define all the versions of such docker images?
You reminded me that the image name should be customizable through risedev.yml.
Also is it possible to clean old versions of these images if we later upgrade the version?
We cannot tell if the image is pulled by RiseDev or the user, so let's just leave it to the user.
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
kwannoel
reviewed
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bugen Zhao i@bugenzhao.comI hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See #16903 for the background.
Use docker image
confluentinc/cp-kafkato start Kafka in RiseDev.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.