-
Notifications
You must be signed in to change notification settings - Fork 545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cdc): add a parameter to control timeout of cdc source waiting time #16598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Customer-facing issue, so LGTM. Best if we can add test cases for this.
e.g.
- Add the complex catalog.
- Show that it takes a long time and timeout occurs.
Then subsequently we can optimize this path as well without having to change timeout, since we have a repro case.
Added an issue to track. #16622 |
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
cda3e32
to
f438137
Compare
The error message is not clear. Let's improve it later |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In our production environment, we found one case that the upstream system's table schema was too complicated so that takes long time to fetch. The time required exceeded the preset timeout threshold in #14406 and leads to the failure of source creation. In this PR, we add a runtime parameter to control it. If a user encounter a error like this when creating cdc source:
he can run
SET cdc_source_wait_streaming_start_timeout TO 120;
to increase timeout from the default 30s to 120s can recreate the source.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
risingwavelabs/risingwave-docs#2126