Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add barrier align metrics for merge executor #16898

Merged
merged 3 commits into from
May 23, 2024
Merged

feat: add barrier align metrics for merge executor #16898

merged 3 commits into from
May 23, 2024

Conversation

lmatz
Copy link
Contributor

@lmatz lmatz commented May 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

dev=> create table t(v1 int);
CREATE_TABLE
dev=> create materialized view m as select * from t;
CREATE_MATERIALIZED_VIEW

SCR-20240523-js3

Merge is different in the sense that it merges input from all the upstream actors belonging to the same fragment.
Join and DynamicFilter merges input from different upstream fragments

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@lmatz lmatz requested a review from st1page May 23, 2024 06:34
@lmatz lmatz added the need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.9 after the current PR is merged label May 23, 2024
@lmatz lmatz enabled auto-merge May 23, 2024 08:48
@lmatz lmatz added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 6170d4c May 23, 2024
27 of 28 checks passed
@lmatz lmatz deleted the lz/metrics branch May 23, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.9 after the current PR is merged type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants