Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean dirty state and notify for expired worker nodes in cluster controller #16901

Merged
merged 3 commits into from
May 24, 2024

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented May 23, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #16884 , previously when worker node is expired, the in-memory worker extra info is not cleaned and the delete operation is not notified. This will cause CN to send a heartbeat to meta after networkchaos but not receives the correct error message and exit as expect. Without re-registering, it will result in no available nodes for auto scaling in recovery.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 added the need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.9 after the current PR is merged label May 23, 2024
@yezizp2012 yezizp2012 requested a review from fuyufjh May 23, 2024 08:55
src/meta/src/controller/cluster.rs Outdated Show resolved Hide resolved
yezizp2012 and others added 2 commits May 24, 2024 12:00
@yezizp2012 yezizp2012 added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit e7c1035 May 24, 2024
28 of 29 checks passed
@yezizp2012 yezizp2012 deleted the fix/ctl-expire-worker branch May 24, 2024 05:50
github-actions bot pushed a commit that referenced this pull request May 24, 2024
… controller (#16901)

Co-authored-by: Bugen Zhao <i@bugenzhao.com>
github-merge-queue bot pushed a commit that referenced this pull request May 24, 2024
… controller (#16901) (#16918)

Co-authored-by: August <pin@singularity-data.com>
Co-authored-by: Bugen Zhao <i@bugenzhao.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/run-e2e-single-node-tests need-cherry-pick-release-1.9 Open a cherry-pick PR to branch release-1.9 after the current PR is merged type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chaos Mesh networkchaos meta inject barrier failed
2 participants