Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add architecture-design doc #1698

Merged
merged 3 commits into from
Apr 11, 2022
Merged

doc: add architecture-design doc #1698

merged 3 commits into from
Apr 11, 2022

Conversation

neverchanje
Copy link
Contributor

What's changed and what's your intention?

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@github-actions github-actions bot added the component/doc Issues about documentation. label Apr 8, 2022
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1698 (36a4772) into main (d41a605) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 36a4772 differs from pull request most recent head 3cb2f91. Consider uploading reports for the commit 3cb2f91 to get more accurate results

@@             Coverage Diff              @@
##               main    #1698      +/-   ##
============================================
- Coverage     69.44%   69.44%   -0.01%     
  Complexity     2766     2766              
============================================
  Files          1059     1059              
  Lines         93400    93400              
  Branches       1790     1790              
============================================
- Hits          64859    64857       -2     
- Misses        27650    27652       +2     
  Partials        891      891              
Flag Coverage Δ
java 61.01% <ø> (ø)
rust 71.16% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/filesystem/file_common.rs 80.35% <0.00%> (-0.45%) ⬇️
src/common/src/types/ordered_float.rs 23.50% <0.00%> (-0.20%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more


* **Frontend**: Frontend is a stateless proxy that accepts user queries through Postgres protocol. It is responsible for parsing, validation, optimization, and answering the results of each individual query.
* **ComputeNode**: ComputeNode is responsible to execute the optimized query plan.
* **MetaServer**: The central metadata management service. It also acts as a failure detector that periodically sends a heartbeat to every Frontends and ComputeNode-s in the cluster.
Copy link
Contributor

@fuyufjh fuyufjh Apr 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"ComputeNode-s" looks weird to me. How about just "compute nodes"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sends a heartbeat to every... --> sends heartbeats to frontend and compute nodes.

Also not sure if we want to change "ComputeNode" to "Compute"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compute is somewhat ambiguous; I still prefer to compute nodes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So shall we replace "ComputeNode-s" to "compute nodes"?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can say "frontend nodes", "compute nodes", and "meta nodes" (do we have more than one meta nodes in one cluster?)

I think we can move the content in this document to the "Architecture" article (https://www.risingwave.dev/docs/latest/architecture/) in our user docs. Currently, the Architecture page is a bit too simple.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/architecture-design.md Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2022

CLA assistant check
All committers have signed the CLA.

@neverchanje neverchanje merged commit 06bcfa9 into main Apr 11, 2022
@neverchanje neverchanje deleted the wt-doc branch April 11, 2022 05:48
@jon-chuang
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants