Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docker): add docker-compose.yml #1705

Merged
merged 3 commits into from
Apr 14, 2022
Merged

feat(docker): add docker-compose.yml #1705

merged 3 commits into from
Apr 14, 2022

Conversation

Gogomoe
Copy link
Contributor

@Gogomoe Gogomoe commented Apr 8, 2022

What's changed and what's your intention?

Add docker-compose.yml.
This version is keep simple for verifying availability. It only setup necessary components such as minio, metanode, computenode and frontend.
Plan to add Redpanda later. Maybe refactor network configuration.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

#1606

@Gogomoe Gogomoe changed the title fear(docker): add docker-compose.yml feat(docker): add docker-compose.yml Apr 8, 2022
@neverchanje
Copy link
Contributor

neverchanje commented Apr 8, 2022

We should add a few lines of doc on docker/README.md.

@CLAassistant
Copy link

CLAassistant commented Apr 8, 2022

CLA assistant check
All committers have signed the CLA.

docker/docker-compose.yml Outdated Show resolved Hide resolved
docker/docker-compose.yml Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 9, 2022

Codecov Report

Merging #1705 (8e112dd) into main (2576165) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1705      +/-   ##
==========================================
- Coverage   70.79%   70.79%   -0.01%     
==========================================
  Files         608      607       -1     
  Lines       79613    79593      -20     
==========================================
- Hits        56366    56349      -17     
+ Misses      23247    23244       -3     
Flag Coverage Δ
rust 70.79% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor_v2/lookup/impl_.rs 97.93% <0.00%> (-0.09%) ⬇️
src/stream/src/executor_v2/mod.rs 65.21% <0.00%> (ø)
src/stream/src/executor_v2/error.rs 0.00% <0.00%> (ø)
src/stream/src/executor_v2/lookup.rs 25.00% <0.00%> (ø)
src/stream/src/executor_v2/lookup/tests.rs 100.00% <0.00%> (ø)
src/stream/src/executor_v2/barrier_align.rs
src/stream/src/executor_v2/lookup/sides.rs 30.43% <0.00%> (+19.32%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@twocode twocode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Cool!
Please add steps in the docker readme. You may do that with the Redpanda PR.

@Gogomoe Gogomoe merged commit 850aca0 into main Apr 14, 2022
@Gogomoe Gogomoe deleted the chuan/docker_compose branch April 14, 2022 04:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants