Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): change Kafka to Apache Kafka #1725

Merged
merged 3 commits into from
Apr 8, 2022
Merged

docs(readme): change Kafka to Apache Kafka #1725

merged 3 commits into from
Apr 8, 2022

Conversation

Sunt-ing
Copy link
Contributor

@Sunt-ing Sunt-ing commented Apr 8, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)

Change Kafka to Apache Kafka.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@Sunt-ing Sunt-ing requested review from lmatz and yingjunwu April 8, 2022 14:51
@github-actions github-actions bot added the component/doc Issues about documentation. label Apr 8, 2022
@CLAassistant
Copy link

CLAassistant commented Apr 8, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sunt-ing Sunt-ing enabled auto-merge (squash) April 8, 2022 15:05
@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1725 (90a69cc) into main (8c8401b) will decrease coverage by 19.21%.
The diff coverage is 5.28%.

❗ Current head 90a69cc differs from pull request most recent head 1e2f301. Consider uploading reports for the commit 1e2f301 to get more accurate results

@@             Coverage Diff             @@
##             main    #1725       +/-   ##
===========================================
- Coverage   71.31%   52.09%   -19.22%     
===========================================
  Files         599      621       +22     
  Lines       77662   108564    +30902     
===========================================
+ Hits        55384    56558     +1174     
- Misses      22278    52006    +29728     
Flag Coverage Δ
rust 52.09% <5.28%> (-19.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/prost/src/common.serde.rs 0.00% <0.00%> (ø)
rust/prost/src/ddl_service.rs 0.00% <0.00%> (ø)
rust/prost/src/ddl_service.serde.rs 0.00% <0.00%> (ø)
rust/prost/src/hummock.serde.rs 0.00% <ø> (ø)
rust/prost/src/meta.serde.rs 0.00% <ø> (ø)
rust/prost/src/plan.serde.rs 2.37% <ø> (ø)
rust/prost/src/stream_plan.serde.rs 11.15% <ø> (ø)
rust/prost/src/stream_service.serde.rs 0.00% <0.00%> (ø)
rust/prost/src/task_service.serde.rs 0.00% <0.00%> (ø)
rust/prost/src/meta.rs 0.73% <0.82%> (ø)
... and 17 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Collaborator

@TennyZhuang TennyZhuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sunt-ing Sunt-ing merged commit 124bba4 into main Apr 8, 2022
@Sunt-ing Sunt-ing deleted the sunt_fix_readme branch April 8, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants