-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cleanup unimplemented #1731
chore: cleanup unimplemented #1731
Conversation
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! We will fix the CI problem next workday and merge after that #1727
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
3b100db
to
de1ac56
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! LGTM.
It seems that the format & clippy check won't pass after CI is fixed. You may run ./risedev check
locally and follow the instructions.
800b876
to
485372a
Compare
I have run it and fixed all problems. |
Codecov Report
@@ Coverage Diff @@
## main #1731 +/- ##
==========================================
- Coverage 71.17% 71.12% -0.05%
==========================================
Files 601 601
Lines 77937 77983 +46
==========================================
- Hits 55469 55468 -1
- Misses 22468 22515 +47
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
47e4dae
to
c4dd111
Compare
I've tested it locally, and I will merge the PR with admin privilege. We will investigate how to improve our CI for PRs from forks later. Sorry for the less than stellar CI experience. |
Signed-off-by: Weizhen Wang wangweizhen@pingcap.com
What's changed and what's your intention?
ref #1724
Please explain IN DETAIL what the changes are in this PR and why they are needed:
Summarize your change (mandatory)
cleanup part of unimplemented.
How does this PR work? Need a brief introduction for the changed logic (optional)
just remove it. but this PR doesn't contain some changes that
unimplemented
need to refactor part of code.Describe clearly one logical change and avoid lazy messages (optional)
Describe any limitations of the current code (optional)
Checklist
Refer to a related PR or issue link (optional)