Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cleanup unimplemented #1731

Merged
merged 7 commits into from
Apr 12, 2022

Conversation

hawkingrei
Copy link
Contributor

@hawkingrei hawkingrei commented Apr 9, 2022

Signed-off-by: Weizhen Wang wangweizhen@pingcap.com

What's changed and what's your intention?

ref #1724

Please explain IN DETAIL what the changes are in this PR and why they are needed:

  • Summarize your change (mandatory)

    cleanup part of unimplemented.

  • How does this PR work? Need a brief introduction for the changed logic (optional)

    just remove it. but this PR doesn't contain some changes that unimplemented need to refactor part of code.

  • Describe clearly one logical change and avoid lazy messages (optional)

  • Describe any limitations of the current code (optional)

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We will fix the CI problem next workday and merge after that #1727

src/frontend/src/scheduler/execution/query.rs Outdated Show resolved Hide resolved
src/source/src/table_v2.rs Outdated Show resolved Hide resolved
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM.

It seems that the format & clippy check won't pass after CI is fixed. You may run ./risedev check locally and follow the instructions.

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@hawkingrei
Copy link
Contributor Author

hawkingrei commented Apr 11, 2022

Thanks for the PR! LGTM.

It seems that the format & clippy check won't pass after CI is fixed. You may run ./risedev check locally and follow the instructions.

I have run it and fixed all problems.

@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1731 (b6d1ce8) into main (d174bae) will decrease coverage by 0.04%.
The diff coverage is 4.76%.

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
- Coverage   71.17%   71.12%   -0.05%     
==========================================
  Files         601      601              
  Lines       77937    77983      +46     
==========================================
- Hits        55469    55468       -1     
- Misses      22468    22515      +47     
Flag Coverage Δ
rust 71.12% <4.76%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/join/sort_merge_join.rs 73.76% <0.00%> (-0.93%) ⬇️
src/frontend/src/scheduler/execution/query.rs 0.00% <0.00%> (ø)
src/meta/src/hummock/hummock_manager.rs 91.31% <0.00%> (-0.41%) ⬇️
src/source/src/parser/common.rs 73.46% <0.00%> (-6.54%) ⬇️
src/storage/src/hummock/hummock_meta_client.rs 0.00% <0.00%> (ø)
src/storage/src/rocksdb_local_mock.rs 0.00% <0.00%> (ø)
src/stream/src/executor/aggregation/mod.rs 91.93% <0.00%> (-3.07%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 89.89% <0.00%> (-0.25%) ⬇️
...ream/src/executor/managed_state/aggregation/mod.rs 78.87% <0.00%> (-5.98%) ⬇️
src/batch/src/executor/join/nested_loop_join.rs 81.35% <5.00%> (-2.02%) ⬇️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@TennyZhuang
Copy link
Collaborator

I've tested it locally, and I will merge the PR with admin privilege. We will investigate how to improve our CI for PRs from forks later. Sorry for the less than stellar CI experience.

@TennyZhuang TennyZhuang merged commit 41f8a54 into risingwavelabs:main Apr 12, 2022
@hawkingrei hawkingrei deleted the replace_unimplemented branch April 13, 2022 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants