Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(streaming): migrate AppendOnlyTopNExecutor to ExecutorV2 #1739

Merged
merged 2 commits into from
Apr 12, 2022

Conversation

pleiadesian
Copy link
Contributor

What's changed and what's your intention?

As title. This PR depends on #1737.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Close #1738

@codecov
Copy link

codecov bot commented Apr 10, 2022

Codecov Report

Merging #1739 (cb52095) into main (fc93222) will decrease coverage by 0.03%.
The diff coverage is 84.58%.

@@            Coverage Diff             @@
##             main    #1739      +/-   ##
==========================================
- Coverage   71.12%   71.09%   -0.04%     
==========================================
  Files         603      604       +1     
  Lines       78066    78133      +67     
==========================================
+ Hits        55524    55547      +23     
- Misses      22542    22586      +44     
Flag Coverage Δ
rust 71.09% <84.58%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor/test_utils.rs 70.63% <ø> (-6.35%) ⬇️
src/stream/src/executor/top_n_appendonly.rs 0.00% <0.00%> (-84.54%) ⬇️
src/stream/src/executor_v2/mod.rs 55.81% <ø> (ø)
src/stream/src/executor_v2/v1_compat.rs 34.09% <0.00%> (-4.38%) ⬇️
src/stream/src/executor_v2/top_n_executor.rs 45.83% <72.00%> (+28.44%) ⬆️
src/stream/src/executor_v2/top_n_appendonly.rs 91.18% <91.18%> (ø)
src/stream/src/executor_v2/top_n.rs 90.76% <100.00%> (ø)
src/stream/src/executor/mod.rs 57.96% <0.00%> (-1.77%) ⬇️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@skyzh skyzh requested a review from lmatz April 10, 2022 06:54
Copy link
Contributor

@lmatz lmatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Sorry for the delay, a lot of things going on these days...

@pleiadesian pleiadesian merged commit d3c1205 into main Apr 12, 2022
@pleiadesian pleiadesian deleted the wzl/top-n-appendonly-v2 branch April 12, 2022 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stream: migrate TopNAppendOnlyExecutor to ExecutorV2
2 participants