Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binder): bind & plan base table scan #174

Merged
merged 2 commits into from Feb 14, 2022

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Feb 9, 2022

What's changed and what's your intention?

Bind and plan select * from table_name;. Note that the select list (* here) is actually ignored, so it only contains scan but not project yet.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #174 (1a71c72) into main (45e8a90) will increase coverage by 0.48%.
The diff coverage is 92.22%.

❗ Current head 1a71c72 differs from pull request most recent head 904c445. Consider uploading reports for the commit 904c445 to get more accurate results

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #174      +/-   ##
============================================
+ Coverage     74.07%   74.55%   +0.48%     
+ Complexity     2665     2654      -11     
============================================
  Files           850      842       -8     
  Lines         48119    47908     -211     
  Branches       1583     1562      -21     
============================================
+ Hits          35643    35720      +77     
+ Misses        11666    11389     -277     
+ Partials        810      799      -11     
Flag Coverage Δ
java 62.08% <ø> (+0.11%) ⬆️
rust 79.93% <92.22%> (+0.62%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
rust/frontend/src/binder/expr/binary_op.rs 66.66% <ø> (ø)
rust/frontend/src/binder/expr/mod.rs 85.71% <ø> (ø)
rust/frontend/src/binder/values.rs 100.00% <ø> (+9.75%) ⬆️
rust/frontend/src/handler/mod.rs 100.00% <ø> (+10.00%) ⬆️
rust/frontend/src/planner/mod.rs 100.00% <ø> (ø)
rust/frontend/src/planner/select.rs 66.66% <66.66%> (ø)
rust/frontend/src/binder/table_ref.rs 81.48% <81.48%> (ø)
rust/frontend/src/binder/expr/value.rs 90.90% <100.00%> (+1.16%) ⬆️
rust/frontend/src/binder/mod.rs 100.00% <100.00%> (ø)
rust/frontend/src/binder/query.rs 100.00% <100.00%> (ø)
... and 112 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69f5f6...904c445. Read the comment docs.

@xiangjinwu xiangjinwu force-pushed the rust-frontend-binder-base-table-scan branch from 904c445 to 3c419a5 Compare February 14, 2022 03:45
@xiangjinwu xiangjinwu marked this pull request as ready for review February 14, 2022 05:14
@xiangjinwu xiangjinwu changed the title feat(binder): (WIP) bind & plan base table scan feat(binder): bind & plan base table scan Feb 14, 2022
@xiangjinwu xiangjinwu merged commit 8abba6d into main Feb 14, 2022
@xiangjinwu xiangjinwu deleted the rust-frontend-binder-base-table-scan branch February 14, 2022 09:24
@BowenXiao1999 BowenXiao1999 mentioned this pull request Feb 15, 2022
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants