fix(source): build connector when calling next
#1746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
BugenZhao
approved these changes
Apr 11, 2022
Comment on lines
+44
to
+45
| /// the future that builds stream_reader. It is required because source should not establish | ||
| /// connections to the upstream before `next` is called |
There was a problem hiding this comment.
We can avoid this when we migrate SourceExecutor to executor v2. 😁
There was a problem hiding this comment.
next time for sure 👍
The migration will happen after making source running!
Signed-off-by: tabVersion <tabvision@bupt.icu>
skyzh
approved these changes
Apr 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #1746 +/- ##
==========================================
- Coverage 71.16% 71.16% -0.01%
==========================================
Files 600 600
Lines 77727 77743 +16
==========================================
+ Hits 55317 55328 +11
- Misses 22410 22415 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
setup timed out, need merge #1752 first |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Please explain IN DETAIL what the changes are in this PR and why they are needed:
in prev impl, connection to upstream is established when source is registered. Here to change that into a future and await when calling next, which means no connection is built until there is data demand.
Checklist
Refer to a related PR or issue link (optional)