Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(debeizum): upgrade version of debeizum from 2.4.2 to 2.6.2 #17504

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Jun 28, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Due to some fixes/fetures requirements, tentatively upgrade the dependent version of debeizum from 2.4.2.Final to 2.6.2.Final.

  1. https://issues.redhat.com/browse/DBZ-7933?jql=component%20%3D%20sqlserver-connector%20AND%20text%20~%20%22time%22 It's a time precision issue from Debezium. The debezium developers fix it in 2.7.0 (PR). So I was planning to upgrade to 2.7.0.Final directly, which was released on June 27. After testing, it still contains some weird bugs in mysql-cdc support. THe error log is here.
  2. In feat(cdc): support sql server cdc #17429, I found that the current 2.4.2.Final does not support retrieve schema history from upstream sql server automatically. While after 2.6.0, recovery snapshot mode is added to support recovery from empty schema history storage. snapshot.mode. If we keep using 2.4.2, we need to find a way to store the schema history, which is non-trivial, making the JVM stateful.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@KeXiangWang KeXiangWang added ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. and removed type/feature labels Jun 28, 2024
@tabVersion
Copy link
Contributor

Waiting for @StrikeW 's review.

@StrikeW StrikeW changed the title feat(debeizum): upgrade the dependent version of debeizum from 2.4.2.Final… feat(debeizum): upgrade version of debeizum from 2.4.2 to 2.6.2 Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change ci/run-backwards-compat-tests Run backwards compatibility tests in your PR. type/feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants