feat: support config sql metastore using username and password by env #17530
+109
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yezizp2012
added
the
user-facing-changes
fuyufjh
reviewed
Jul 3, 2024
kwannoel
reviewed
Jul 3, 2024
| pub sql_username: String, | ||
| /// Password of sql backend, required when meta backend set to MySQL or PostgreSQL. | ||
| #[clap(long, default_value = "")] | ||
| pub sql_password: String, |
There was a problem hiding this comment.
Suggested change
| pub sql_password: String, | |
| pub sql_password: Secret<String>, |
Does this need to be secret as well?
There was a problem hiding this comment.
I'm not sure. Do we need it? @zwang28
kwannoel
reviewed
Jul 3, 2024
fuyufjh
approved these changes
Jul 3, 2024
Merged
2 tasks
yezizp2012
added
the
need-cherry-pick-release-1.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Resolve #16998 .
sqlite,postgresandmysqlin--backend.--sql-username,--sql-passwordand--sql-database, which only required forpostgresandmysql.--sql-endpointshould be configured in format{host}:{port}if the backend is set topostgresandmysql. Forsqliteit should be the file path.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.
Support configure sql metastore using username, password and database separately. The corresponding envs are also supported.
sqlite,postgresandmysqlin--backend.--sql-username,--sql-passwordand--sql-database, which only required forpostgresandmysql.--sql-endpointshould be configured in format{host}:{port}if the backend is set topostgresandmysql. Forsqliteit should be the file path.