Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable meta recovery process in CI #1754

Merged
merged 4 commits into from
Apr 11, 2022
Merged

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Apr 11, 2022

What's changed and what's your intention?

As title, disable meta recovery process in CI. Because entering recovery is not necessary when CI fails due to some bugs, besides a lot of invalid logs will generated. I will add extra test in CI for recovery in the future.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/meta/src/barrier/mod.rs Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1754 (efa9da5) into main (06bcfa9) will decrease coverage by 0.21%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##             main    #1754      +/-   ##
==========================================
- Coverage   71.37%   71.16%   -0.22%     
==========================================
  Files         600      600              
  Lines       77726    77732       +6     
==========================================
- Hits        55477    55315     -162     
- Misses      22249    22417     +168     
Flag Coverage Δ
rust 71.16% <15.38%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/utils/logging/src/lib.rs 0.78% <0.00%> (ø)
src/meta/src/barrier/mod.rs 70.52% <16.00%> (-2.96%) ⬇️
src/meta/src/barrier/recovery.rs 0.00% <0.00%> (-59.20%) ⬇️
src/meta/src/model/stream.rs 54.14% <0.00%> (-17.20%) ⬇️
src/meta/src/stream/meta.rs 31.75% <0.00%> (-6.87%) ⬇️
src/meta/src/stream/stream_manager.rs 75.75% <0.00%> (-2.78%) ⬇️
src/meta/src/manager/catalog_v2.rs 19.67% <0.00%> (-1.08%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 90.40% <0.00%> (+0.27%) ⬆️
src/meta/src/barrier/command.rs 58.33% <0.00%> (+1.85%) ⬆️
... and 1 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 merged commit 266ca24 into main Apr 11, 2022
@yezizp2012 yezizp2012 deleted the conf-recovery-in-ci branch April 11, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants