Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(risedev): forbid unused parameters in config #1767

Merged
merged 1 commit into from
Apr 11, 2022

Conversation

skyzh
Copy link
Contributor

@skyzh skyzh commented Apr 11, 2022

Signed-off-by: Alex Chi iskyzh@gmail.com

What's changed and what's your intention?

As title

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: Alex Chi <iskyzh@gmail.com>
@skyzh skyzh requested a review from BugenZhao April 11, 2022 09:19
@github-actions github-actions bot added the type/fix Bug fix label Apr 11, 2022
@codecov
Copy link

codecov bot commented Apr 11, 2022

Codecov Report

Merging #1767 (de1ed35) into main (d174bae) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1767   +/-   ##
=======================================
  Coverage   71.17%   71.17%           
=======================================
  Files         601      601           
  Lines       77937    77937           
=======================================
  Hits        55469    55469           
  Misses      22468    22468           
Flag Coverage Δ
rust 71.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/risedevtool/src/config/service_config.rs 0.00% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.

@skyzh skyzh merged commit 2f04635 into main Apr 11, 2022
@skyzh skyzh deleted the skyzh/risedev-misc-improvement branch April 11, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants