Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix distributed query manager bug #1778

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

liurenjie1024
Copy link
Contributor

@liurenjie1024 liurenjie1024 commented Apr 12, 2022

What's changed and what's your intention?

Fix a bug which may lead to schedule failure.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Closes #1723

@github-actions github-actions bot added the type/fix Bug fix label Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1778 (646de15) into main (d0a2928) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1778      +/-   ##
==========================================
- Coverage   71.29%   71.27%   -0.03%     
==========================================
  Files         605      605              
  Lines       78599    78628      +29     
==========================================
- Hits        56041    56040       -1     
- Misses      22558    22588      +30     
Flag Coverage Δ
rust 71.27% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/scheduler/execution/query.rs 0.00% <0.00%> (ø)
src/frontend/src/scheduler/execution/stage.rs 0.00% <0.00%> (ø)
src/connector/src/filesystem/file_common.rs 80.44% <0.00%> (-0.45%) ⬇️
src/common/src/alloc.rs 100.00% <0.00%> (ø)
src/utils/pgwire/src/error.rs 0.00% <0.00%> (ø)
src/common/src/buffer/bitmap.rs 87.64% <0.00%> (ø)
src/frontend/src/handler/set.rs 0.00% <0.00%> (ø)
src/frontend/src/meta_client.rs 0.00% <0.00%> (ø)
src/common/src/buffer/buffer_.rs 78.43% <0.00%> (ø)
src/source/src/connector_source.rs 0.00% <0.00%> (ø)
... and 11 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@liurenjie1024 liurenjie1024 merged commit 32c3dda into main Apr 12, 2022
@liurenjie1024 liurenjie1024 deleted the fix/dist_batch_query_bug branch April 12, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: starting query execution failed: RecvError(())
2 participants