Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(source): doc for data source #1781

Merged
merged 4 commits into from
Apr 12, 2022
Merged

doc(source): doc for data source #1781

merged 4 commits into from
Apr 12, 2022

Conversation

tabVersion
Copy link
Contributor

Signed-off-by: tabVersion tabvision@bupt.icu

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

as title, add data source design doc

  • Summarize your change (mandatory)
  • How does this PR work? Need a brief introduction for the changed logic (optional)
  • Describe clearly one logical change and avoid lazy messages (optional)
  • Describe any limitations of the current code (optional)
    • diagram in SVG format will be available soon

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: tabVersion <tabvision@bupt.icu>
@github-actions github-actions bot added the component/doc Issues about documentation. label Apr 12, 2022
@codecov
Copy link

codecov bot commented Apr 12, 2022

Codecov Report

Merging #1781 (1eb9035) into main (af40194) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1781      +/-   ##
==========================================
- Coverage   71.35%   71.35%   -0.01%     
==========================================
  Files         605      605              
  Lines       78689    78689              
==========================================
- Hits        56150    56148       -2     
- Misses      22539    22541       +2     
Flag Coverage Δ
rust 71.35% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/connector/src/base.rs 0.00% <ø> (ø)
src/connector/src/filesystem/file_common.rs 80.00% <0.00%> (-0.45%) ⬇️
.../src/executor/managed_state/aggregation/extreme.rs 89.89% <0.00%> (-0.27%) ⬇️
src/common/src/types/ordered_float.rs 23.70% <0.00%> (+0.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang enabled auto-merge (squash) April 12, 2022 07:34
Signed-off-by: tabVersion <tabvision@bupt.icu>
@TennyZhuang TennyZhuang merged commit 07fa9f1 into main Apr 12, 2022
@TennyZhuang TennyZhuang deleted the tab/doc-data-source branch April 12, 2022 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/doc Issues about documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants