feat: scheduling splits when creating a materialized view #1788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1788 +/- ##
==========================================
- Coverage 71.33% 71.22% -0.12%
==========================================
Files 605 605
Lines 78729 78931 +202
==========================================
+ Hits 56163 56217 +54
- Misses 22566 22714 +148
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: Shanicky Chen <shanicky@MacBook-Pro-M1-Pro.local>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
Signed-off-by: Peng Chen <peng@singularity-data.com>
shanicky
force-pushed
the
peng/source-manager-v2
branch
from
0056de7
to
242255b
Compare
|
|
Signed-off-by: Peng Chen <peng@singularity-data.com>
tabVersion
reviewed
Apr 12, 2022
| todo!() | ||
| } | ||
| } | ||
| let bootstrap_servers = properties.get(KAFKA_CONFIG_BROKER_KEY).ok_or_else(|| { |
There was a problem hiding this comment.
consider make it a func in common/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
This PR initially provides the ability to
create materialized view from sourceWhen creating the materialized view, the fragmenter generates the corresponding fragment by slicing the graph, and each fragement generates the corresponding actor group by setting the parallelism, during which the stream source actor is found by
SourceNodematching and a one-time split scheduling is performed,Splitis the abstraction of the external partition in theSource,and when the actor is created later, it will start the subscription and consume according to the split information.The subsequent design will asynchronize the split assign and push the split assignment/addition asynchronously through config change barrier after the overall startup, so as to obtain the ability to add dynamic splits and shorten the time to create mv
Checklist
Refer to a related PR or issue link (optional)