fix: fill source id before creating source in compute node #1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BugenZhao
approved these changes
Apr 13, 2022
skyzh
approved these changes
Apr 13, 2022
|
|
||
| self.catalog_manager | ||
| .start_create_source_procedure(&source) | ||
| .await | ||
| .map_err(tonic_err)?; | ||
|
|
||
| // QUESTION(patrick): why do we need to contact compute node on create source |
There was a problem hiding this comment.
Yes, I think we should get rid of this in the future. Source info should be part of the plan node.
Codecov Report
@@ Coverage Diff @@
## main #1806 +/- ##
==========================================
+ Coverage 71.24% 71.33% +0.08%
==========================================
Files 605 605
Lines 78907 79168 +261
==========================================
+ Hits 56220 56476 +256
- Misses 22687 22692 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
zbzbw
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to a related PR or issue link (optional)
close #1805