-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(frontend/expr): unifiy to_expr
and as_expr
, remove redundent code
#1816
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1816 +/- ##
==========================================
+ Coverage 70.84% 70.85% +0.01%
==========================================
Files 610 610
Lines 79689 79684 -5
==========================================
+ Hits 56453 56462 +9
+ Misses 23236 23222 -14
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Condition::as_expr
andCondition::to_expr
are very similar, except for one is for borrowed value and the other one is for owned value. However, these two functions are implemented by copying and pasting code. This pr unifies the borrowed version and the owned version.Checklist