Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(stream): refine TopNExecutorBase #1822

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

TennyZhuang
Copy link
Collaborator

Signed-off-by: TennyZhuang zty0826@gmail.com

What's changed and what's your intention?

Similar to #1795

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

Signed-off-by: TennyZhuang <zty0826@gmail.com>
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L💦TM!

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #1822 (07f8a99) into main (747d2d1) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1822      +/-   ##
==========================================
+ Coverage   70.74%   70.80%   +0.05%     
==========================================
  Files         608      608              
  Lines       79523    79561      +38     
==========================================
+ Hits        56261    56330      +69     
+ Misses      23262    23231      -31     
Flag Coverage Δ
rust 70.80% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/stream/src/executor_v2/top_n.rs 90.64% <0.00%> (-1.16%) ⬇️
src/stream/src/executor_v2/top_n_appendonly.rs 92.74% <0.00%> (+0.35%) ⬆️
src/stream/src/executor_v2/top_n_executor.rs 57.89% <ø> (+12.06%) ⬆️
src/frontend/src/handler/create_source.rs 96.87% <0.00%> (-0.58%) ⬇️
...c/frontend/src/optimizer/plan_node/logical_join.rs 84.90% <0.00%> (-0.25%) ⬇️
...rc/frontend/src/optimizer/plan_node/logical_agg.rs 97.35% <0.00%> (-0.15%) ⬇️
...frontend/src/optimizer/plan_node/logical_filter.rs 97.79% <0.00%> (-0.11%) ⬇️
...rontend/src/optimizer/plan_node/logical_project.rs 97.15% <0.00%> (-0.09%) ⬇️
src/frontend/src/handler/describe.rs 98.91% <0.00%> (ø)
...tend/src/optimizer/plan_node/stream_materialize.rs 89.44% <0.00%> (ø)
... and 12 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@TennyZhuang TennyZhuang merged commit d8fc781 into main Apr 13, 2022
@TennyZhuang TennyZhuang deleted the refactor/simplify-topn-v2 branch April 13, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants