-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(stream): implement LocalSimpleAgg without AggExecutor #1823
Conversation
Signed-off-by: TennyZhuang <zty0826@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Most migrated executors are simply moved to the new directory and the only changes might be the input type currently. I believe a deep review or rewrite might be required. |
Signed-off-by: TennyZhuang <zty0826@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #1823 +/- ##
==========================================
- Coverage 70.72% 70.70% -0.02%
==========================================
Files 611 611
Lines 79896 79861 -35
==========================================
- Hits 56503 56469 -34
+ Misses 23393 23392 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Signed-off-by: TennyZhuang zty0826@gmail.com
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
We can try to remove
AggExecutorWrapper
in executor_v2, due to the following reasons:AggExecutorWrapper
almost do nothing in executor_v2.AggExecutor
will not work.AggExecutorWrapper
still looks like a state machine.We may investigate how to reduce the common codes in executor_v2 later.
Checklist
Refer to a related PR or issue link (optional)