feat(frontend): test create source in yaml #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1824 +/- ##
=======================================
Coverage 70.78% 70.79%
=======================================
Files 608 608
Lines 79569 79613 +44
=======================================
+ Hits 56325 56364 +39
- Misses 23244 23249 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
neverchanje
reviewed
Apr 14, 2022
src/frontend/test_runner/src/lib.rs
Outdated
| pub struct CreateSource { | ||
| row_format: String, | ||
| name: String, | ||
| file_location: Option<String>, |
There was a problem hiding this comment.
Add it back when it's used. Still hard to use file location in test.
Suggested change
| file_location: Option<String>, |
src/frontend/test_runner/src/lib.rs
Outdated
| .await | ||
| } else { | ||
| panic!( | ||
| "{:?} create source need to conclude content or location", |
There was a problem hiding this comment.
Suggested change
| "{:?} create source need to conclude content or location", | |
| "{:?} create source must include `file` for the file content", |
src/frontend/test_runner/src/lib.rs
Outdated
| let placeholder_empty_vec = vec![]; | ||
|
|
||
| // Since temp file will be deleted when it goes out of scope, so create source advance. | ||
| self.create_source_advance(session.clone()).await?; |
There was a problem hiding this comment.
Suggested change
| self.create_source_advance(session.clone()).await?; | |
| self.create_source(session.clone()).await?; |
Btw, "in advance" , not "advance"
…/risingwave into feat/test_create_source
neverchanje
approved these changes
Apr 14, 2022
| @@ -73,6 +75,18 @@ pub struct TestCase { | |||
|
|
|||
| /// Error of optimizer | |||
| pub optimizer_error: Option<String>, | |||
|
|
|||
| /// Support using file content or file location to create source. | |||
There was a problem hiding this comment.
Suggested change
| /// Support using file content or file location to create source. | |
| /// Support using file content to create source. |
| } | ||
|
|
||
| // If testcase have create source info, run sql to create source. | ||
| // Support create source by file content or file location. |
There was a problem hiding this comment.
Suggested change
| // Support create source by file content or file location. | |
| // Support create source by file content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed and what's your intention?
PLEASE DO NOT LEAVE THIS EMPTY !!!
Since now we must create protobuf source by using file location in below format.
This pr supports create protobuf source by using content or location in yaml.
Checklist
Refer to a related PR or issue link (optional)