Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(source): unified util of getting property #1833

Merged
merged 3 commits into from
Apr 14, 2022
Merged

Conversation

neverchanje
Copy link
Contributor

What's changed and what's your intention?

We repeatedly defined macros to obtain property in different places. This PR provides an unified util for all these use-cases.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@neverchanje neverchanje requested review from shanicky and tabVersion and removed request for shanicky April 14, 2022 05:27
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1833 (e7599fe) into main (4f31c18) will increase coverage by 0.02%.
The diff coverage is 50.44%.

@@            Coverage Diff             @@
##             main    #1833      +/-   ##
==========================================
+ Coverage   70.76%   70.79%   +0.02%     
==========================================
  Files         607      608       +1     
  Lines       79619    79666      +47     
==========================================
+ Hits        56344    56399      +55     
+ Misses      23275    23267       -8     
Flag Coverage Δ
rust 70.79% <50.44%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/batch/src/executor/create_source.rs 0.00% <0.00%> (ø)
src/connector/src/base.rs 0.00% <0.00%> (ø)
src/connector/src/kafka/enumerator/client.rs 0.00% <0.00%> (ø)
src/connector/src/lib.rs 85.71% <ø> (ø)
src/connector/src/pulsar/enumerator/client.rs 0.00% <0.00%> (ø)
src/meta/src/stream/source_manager.rs 22.42% <0.00%> (-0.22%) ⬇️
src/source/src/manager.rs 52.36% <0.00%> (+2.36%) ⬆️
src/connector/src/utils.rs 83.82% <83.82%> (ø)
.../src/executor/managed_state/aggregation/extreme.rs 89.89% <0.00%> (-0.27%) ⬇️
... and 2 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neverchanje neverchanje enabled auto-merge (squash) April 14, 2022 05:52
@neverchanje neverchanje merged commit 44f380d into main Apr 14, 2022
@neverchanje neverchanje deleted the wt-source branch April 14, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants