Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): avoid panic when no worker #1834

Merged
merged 2 commits into from
Apr 14, 2022

Conversation

yezizp2012
Copy link
Contributor

@yezizp2012 yezizp2012 commented Apr 14, 2022

What's changed and what's your intention?

PLEASE DO NOT LEAVE THIS EMPTY !!!

Please explain IN DETAIL what the changes are in this PR and why they are needed:

As title.

Checklist

  • I have written necessary docs and comments
  • I have added necessary unit tests and integration tests

Refer to a related PR or issue link (optional)

@yezizp2012 yezizp2012 changed the title Fix/avoid panic when no worker fix(frontend): avoid panic when no worker Apr 14, 2022
@yezizp2012 yezizp2012 enabled auto-merge (squash) April 14, 2022 06:01
@github-actions github-actions bot added the type/fix Bug fix label Apr 14, 2022
@codecov
Copy link

codecov bot commented Apr 14, 2022

Codecov Report

Merging #1834 (621b0ea) into main (4f31c18) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1834      +/-   ##
==========================================
- Coverage   70.76%   70.76%   -0.01%     
==========================================
  Files         607      607              
  Lines       79619    79623       +4     
==========================================
  Hits        56344    56344              
- Misses      23275    23279       +4     
Flag Coverage Δ
rust 70.76% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/frontend/src/scheduler/execution/stage.rs 0.00% <0.00%> (ø)
src/frontend/src/scheduler/query_manager.rs 7.44% <0.00%> (ø)
src/frontend/src/scheduler/worker_node_manager.rs 18.42% <0.00%> (-2.17%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@yezizp2012 yezizp2012 merged commit 0597bab into main Apr 14, 2022
@yezizp2012 yezizp2012 deleted the fix/avoid-panic-when-no-worker branch April 14, 2022 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants