-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(hummock): remove redundant code in state store implementation #1859
Conversation
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
Signed-off-by: Bugen Zhao <i@bugenzhao.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 715 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
712 | 1 | 2 | 0 |
Click to see the invalid file list
- src/storage/src/hummock/state_store.rs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
license-eye has totally checked 715 files.
Valid | Invalid | Ignored | Fixed |
---|---|---|---|
712 | 1 | 2 | 0 |
Click to see the invalid file list
- src/storage/src/hummock/state_store.rs
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Codecov Report
@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
- Coverage 70.87% 70.86% -0.01%
==========================================
Files 610 611 +1
Lines 79659 79623 -36
==========================================
- Hits 56455 56428 -27
+ Misses 23204 23195 -9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
What's changed and what's your intention?
There're some redundant codes in
iter
vsreverse_iter
,scan
vsreverse_scan
.Checklist
Refer to a related PR or issue link (optional)